Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 0007: C++ style // one-line comments #2074

Merged
merged 1 commit into from
Dec 20, 2021
Merged

PEP 0007: C++ style // one-line comments #2074

merged 1 commit into from
Dec 20, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 17, 2021

The removed sentence is sort of a repetition of this previous text:

  • Python versions greater than or equal to 3.6 use C89 with several select C99 features:
    [...]
    • C++-style line comments

Versions of Python earlier than 3.6 are EOL'd. Therefore this piece of information has lost its importance, and doesn't warrant repetition.

I explain why I find this sentence is ambiguous in #2072 (comment).

This actually is sort of a repetition:

	* Python versions greater than or equal to 3.6 use C89
	  with several select C99 features:
	  [...]
	  - C++-style line comments

Versions of Python earlier than 3.6 are EOL'd. Therefore this
piece of information has lost its importance, and doesn't warrant
repetition.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gvanrossum gvanrossum merged commit ec3ac5b into python:main Dec 20, 2021
@gvanrossum
Copy link
Member

@DimitriPapadopoulos Thanks for your contribution (and your patience!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants