PEP 467: Drop the bchr builtin proposal #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make it clearer that memoryview isn't an open issue for the PEP, it's explicitly outside the PEP's scope.
ncoghlan
commented
Sep 9, 2021
|
|
||
| Updating ``memoryview`` with these new methods is outside the scope of this PEP. | ||
| Updating ``memoryview`` with the new item retrieval methods is outside the scope | ||
| of this PEP. |
There was a problem hiding this comment.
This section looked weird to me when I was adding the new design discussion entry, so I tweaked it a bit:
- it's a deliberate scope limitation, not an open issue
- only the item retrieval methods (
getbyte(),iterbytes()) potentially make sense for memory views, the alternate constructors would never be relevant
ethanfurman
approved these changes
Sep 9, 2021
ethanfurman
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make it clearer that memoryview isn't an open issue for the PEP,
it's explicitly outside the PEP's scope.