-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 8: Removed references to Python 2 #2059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes on things I wasn't sure about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo and formatting
Co-authored-by: Jelle Zijlstra <[email protected]>
I'll let you all come to a conclusion, and then as the nominal PEP's author I'd like to have the final say. (I'll ask Barry too.) |
I"m not sure if you want anyone else to review, but I believe I've responded to all comments so far. I think it's ready. |
Two nits from me, otherwise LGTM. |
Before removing all Python 2 references from PEP 8, I suggest a tag or branch be created with a meaningful name, something like "lastpy2pep8". It should be a one-and-done sorry of thing and make it easier for people still maintaining tools which support Python 2 (such as the pep8 app in PyPI) to refer to (or to publish). |
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am totally cool with this! Will land now, since it's been quiet here for a while.
Done! |
After a brief discussion on python-dev, I've removed all references to Python 2 in PEP 8.
(https://mail.python.org/archives/list/[email protected]/thread/MK7N36L3XCXVY5R4DIIYIDU2W7EGJKZ3/)
There are a few items I'm not totally sure about -- see line by line comments.
Also, it was suggested that we might want to put a note in for folks indicating that they can find Python2 relevant versions in the history. I don't think that necessary, but if anyone else wants to add that, of course they can.