Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP-654: ExceptionGroup --> exception group in prose #1855

Merged
merged 3 commits into from
Mar 2, 2021
Merged

PEP-654: ExceptionGroup --> exception group in prose #1855

merged 3 commits into from
Mar 2, 2021

Conversation

iritkatriel
Copy link
Member

Use "exception group" instead of ExceptionGroup to make it flow better now that we also have BaseExceptionGroup.

@iritkatriel iritkatriel requested review from 1st1 and gvanrossum March 2, 2021 02:01
gvanrossum
gvanrossum reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, the rest LGTM (I didn't check every diff chunk but I sampled some and everything looks fine).

pep-0654.rst Outdated Show resolved Hide resolved
pep-0654.rst Outdated Show resolved Hide resolved
iritkatriel and others added 2 commits March 2, 2021 02:40
@iritkatriel @gvanrossum
White flag
f7949d1 
Co-authored-by: Guido van Rossum <[email protected]>
@iritkatriel @gvanrossum
Whitespace
e27d17e 
Co-authored-by: Guido van Rossum <[email protected]>
@gvanrossum gvanrossum merged commit a3f0183 into python:master Mar 2, 2021
@iritkatriel iritkatriel deleted the BaseExceptionGroup2 branch November 5, 2021 10:28
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @1st1 @gvanrossum