CI: Only deploy for upstream to prevent forks failing #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Jul 24, 2020
AA-Turner
pushed a commit
to AA-Turner/peps
that referenced
this pull request
Aug 15, 2020
AA-Turner
pushed a commit
to AA-Turner/peps
that referenced
this pull request
Aug 15, 2020
mnm678
pushed a commit
to mnm678/peps
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork CI builds fail on the deploy step, because they (correctly) don't have the deploy credentials.
For example, failing fork build:
Instead, only do the deploy for this upstream
python/pepsrepo.For example, passing fork build:
This will encourage people to make sure tests pass on forks, and less likely to submit a failing PR.
Travis CI docs