tests: Avoid side effect of COLUMNS env var #9813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests rely on getting the default width of a terminal for rendering test output. Some PTY environments (in my case the Emacs shell) set the env var `COLUMNS` to the terminal width, which can cause several tests to fail due to formatting mismatches. Prior to running thesee tests, mock out `sys.environ`, removing the `COLUMNS` env var when present.
gvanrossum
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several tests rely on getting the default width of a terminal for
rendering test output. Some PTY environments (in my case the Emacs
shell) set the env var
COLUMNSto the terminal width, which cancause several tests to fail due to formatting mismatches.
Prior to running thesee tests, mock out
sys.environ, removing theCOLUMNSenv var when present.Test Plan
The change should only effect environments like my own. After this change, tests pass in my environment. The change can be manually tested in other environments by running
before, then after applying the change.