[mypyc] Merge dict get op and generic power op #9347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Aug 25, 2020
| @@ -63,6 +63,18 @@ PyObject *CPyDict_Get(PyObject *dict, PyObject *key, PyObject *fallback) { | |||
| return res; | |||
| } | |||
|
|
|||
| PyObject *CPyDict_GetWithNone(PyObject *dict, PyObject *key) { | |||
There was a problem hiding this comment.
What about just calling CPyDict_Get in the body with an extra Py_None argument? The extra call should have minimal performance impact, and this would reduce some code repetition?
Declare the function in CPy.h.
| @@ -35,3 +35,8 @@ PyObject *CPyIter_Next(PyObject *iter) | |||
| { | |||
| return (*iter->ob_type->tp_iternext)(iter); | |||
| } | |||
|
|
|||
| PyObject *CPyNumber_Power(PyObject *base, PyObject *index) | |||
There was a problem hiding this comment.
Declare this in CPy.h (it's unfortunate that this isn't caught by our tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
getop withNoneas default value for dict, and a power op for generic numbers, which completes the support ofgeneric_ops.pyanddict_ops.py