Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mypy daemon docs #9337

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Update mypy daemon docs #9337

merged 1 commit into from
Aug 22, 2020

Conversation

triqp
Copy link
Contributor

@triqp triqp commented Aug 22, 2020

  • Fix grammatical error for CLI
  • Rest of the page uses "type check" opposed to "typecheck"
  • Change invalid "dymypy" command to "dmypy"

hauntsaninja
hauntsaninja approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gvanrossum
gvanrossum approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvanrossum gvanrossum merged commit 2b704df into python:master Aug 22, 2020
@gvanrossum
Copy link
Member

@triqp Are you planning to contribute more to mypy? Or did these just catch your eye while you were browsing the docs? Or was this part of a school assignment "contribute to a GitHub project"?

@triqp
Copy link
Contributor Author

triqp commented Aug 22, 2020 •
edited
Loading

@gvanrossum I utilize mypy at my job, and am currently researching potential topics related to Python/typing for my master's thesis. I was reading the docs to getter a deeper understanding of the library and any potential areas for improvement, but I do plan on contributing more.

I haven't done a deep-dive into the issues yet, but if you have any input on potential areas for improvement I'd be happy to entertain them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@triqp @gvanrossum @hauntsaninja