Fixed stubgen parsing generics from C extensions #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Jun 8, 2020
| r'(^|[\[, ]+)' + re.escape(module.__name__ + '.'), | ||
| r'\1', | ||
| typ, | ||
| ) |
There was a problem hiding this comment.
It would be nice to have some unit tests for the new functionality, since this logic is non-trivial. You can add them to mypy/test/teststubgen.py.
(Maybe also modify this so that the module name is passed instead of a module object.)
There was a problem hiding this comment.
Ah I couldn't find the tests for stubgen. I'll get those added. Thanks for the review!
AWhetter
force-pushed
the
fix_stubgen_generic_import
branch
from
0305fab to
64ebff3
Compare
AWhetter
force-pushed
the
fix_stubgen_generic_import
branch
from
64ebff3 to
cf31345
Compare
AWhetter
force-pushed
the
fix_stubgen_generic_import
branch
from
cf31345 to
0c3a7bd
Compare
|
Is there anything else that I can do to help progress this pull request? |
JukkaL
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybind11 is capable of producing type signatures that use generics (for example https://github.com/pybind/pybind11/blob/4e3d9fea74ed50a042d98f68fa35a3133482289b/include/pybind11/stl.h#L140). A user may also opt to write a signature in the docstring that uses generics.
Currently when stubgen parses one of these generics, it attempts to import a part of it. For example if a docstring had
my_func(str, int) -> List[mypackage.module_being_parsed.MyClass], the resulting stub file tries to importList[mypackage.module_being_parsed.This change fixes this behaviour by breaking the found type down into the multiple types around
[],characters, adding any imports from those types that are needed, and then stripping out the name of the module being parsed.