Generate an error if trying to use @final with TypedDict #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Nov 4, 2019
Co-Authored-By: Ivan Levkivskyi <[email protected]>
|
@ilevkivskyi I add a test case called |
ilevkivskyi
reviewed
Nov 4, 2019
test-data/unit/check-typeddict.test
Outdated
| str_val: str | ||
|
|
||
| [builtins fixtures/dict.pyi] | ||
| [typing fixtures/typing-full.pyi] |
There was a problem hiding this comment.
Please add a newline at the end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7849
This fix modifies function
analyze_classinmypy/semanal.py, if the analyzer identifies aTypedDict, it then traverses all decorators and checks if@finalexists, and if so, generate an error.The code is very straightforward, but I think it has room for potential improvement in terms of clarity.