[suggest] Support refining existing type annotations #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
suggest-refine
branch
from
d2d1a9d to
d9f19dd
Compare
ilevkivskyi
reviewed
Nov 1, 2019
msullivan
force-pushed
the
suggest-refine
branch
from
d9f19dd to
0ac4544
Compare
|
I've rewritten the merge logic completely to not use either meet or join |
|
Oh wow this one that is failing only under mypyc is going to be exciting. That is frankly super rare! |
ilevkivskyi
approved these changes
Nov 2, 2019
mypy/suggestions.py
Outdated
| new_items.append(lhs) | ||
|
|
||
| # We don't ever want to drop None while making these things and | ||
| # make_simplified_union calls join which cases |
There was a problem hiding this comment.
It looks like something is wrong with grammar here.
| if isinstance(t, UnionType): | ||
| return refine_union(t, s) | ||
|
|
||
| return t |
There was a problem hiding this comment.
I would add couple special cases (not important however) for type and tuple. These two are represented by instances, but can be refined by Type[C] and Tuple[X, Y, ...].
|
The failure with mypyc is due to #7854 |
msullivan
force-pushed
the
suggest-refine
branch
from
1fa48db to
66d3cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.