Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve missing import message #7698

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Improve missing import message #7698

merged 1 commit into from
Oct 28, 2019

Conversation

Lewiscowles1986
Copy link
Contributor

@Lewiscowles1986 Lewiscowles1986 commented Oct 11, 2019 •
edited
Loading

It can be difficult to understand the missing module error message at times.

Changes

Cannot find module named '{}'

to

Cannot find implementation or library stub for module named '{}'

This improves #4542

Great thanks to all that participated in that discussion, this is all of our work.

@JukkaL

@Lewiscowles1986 Lewiscowles1986 marked this pull request as ready for review October 11, 2019 17:41
msullivan
msullivan approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, assuming we're hapy with the wording. @JukkaL?

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 28, 2019

Looks good!

@JukkaL JukkaL merged commit 70f2857 into python:master Oct 28, 2019
@nicoe nicoe mentioned this pull request Oct 28, 2019
Closed
dmtucker added a commit to dmtucker/pytest-mypy that referenced this pull request Dec 29, 2019
@dmtucker
Fix tests for mypy>=0.750
5f103b7 
python/mypy#7698
@dmtucker dmtucker mentioned this pull request Dec 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lewiscowles1986 @JukkaL @msullivan