Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TypedDict initialization from Type #16963

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Allow TypedDict initialization from Type #16963

merged 1 commit into from
Mar 1, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Feb 29, 2024

Fixes #11644

@cdce8p cdce8p mentioned this pull request Feb 29, 2024
Merged
32 tasks
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@hauntsaninja hauntsaninja merged commit 3c87af2 into python:master Mar 1, 2024
18 checks passed
@cdce8p cdce8p deleted the fix-typeddict-init-from-type branch March 1, 2024 08:26
@cdce8p cdce8p mentioned this pull request Mar 27, 2024
Merged
JelleZijlstra pushed a commit that referenced this pull request Mar 27, 2024
@cdce8p
Fix TypedDict init from Type with optional keys (#17068)
4310586 
Followup to #16963
Correctly set optional and required keys for the TypedDict init
callable.

Ref: #11644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
topic-typed-dict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems passing around TypedDict and using it in Union.
2 participants
@cdce8p @hauntsaninja