Move test data out of mypy/ #1667
Conversation
| @@ -1,6 +1,5 @@ | |||
| """Tests for the mypy parser | |||
|
|
|||
| Test case descriptions are in files test/data/parse[-errors].test.""" | |||
| """ | |||
There was a problem hiding this comment.
Proper docstring style is actually to have the close """ on the same line iff it's a single line. So it was wrong, and it's still wrong. :-)
|
LGTM except for the docstring nit! I've wanted this for so long... (I also want all test code out of the mypy package, but that may have to wait and it's also a bit debatable.) |
|
Pushed a fix to that docstring. :-) We do use |
|
OK. LGTM. --Guido (mobile)
|
|
(We're going to hold this a couple of days for the 0.4.2 release, after which I'll rebase and merge.) |
|
This is good to rebase and merge now! |
This makes it easier to grep through our codebase to find things quickly without getting noise from matches in our tests -- after all, our test data naturally has a lot of Python code, just like mypy itself. #compilerworldproblems Specifically, move what was mypy/test/data/ inside a new directory test-data/. While we're at it, tuck samples/ and stdlib-samples/ under test-data/ too. This is probably still not the perfect layout (e.g., does stdlib-samples/ need to be special, or can it just be more samples organized into a directory under samples/?), but with all the file moves in this commit I wanted to keep the necessary logic changes to an absolute minimum for ease of reading and reviewing. The `-M` flag to `git show/diff/log` is highly recommended when looking at this commit.
This makes it easier to grep through our codebase to find things
quickly without getting noise from matches in our tests --
after all, our test data naturally has a lot of Python code,
just like mypy itself. #compilerworldproblems
Specifically, move what was mypy/test/data/ inside a new directory
test-data/. While we're at it, tuck samples/ and stdlib-samples/
under test-data/ too. This is probably still not the perfect layout
(e.g., does stdlib-samples/ need to be special, or can it just be more
samples organized into a directory under samples/?), but with all the
file moves in this commit I wanted to keep the necessary logic changes
to an absolute minimum for ease of reading and reviewing.
The
-Mflag togit show/diff/logis highly recommended whenlooking at this commit.