Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and rename overload-overlap error code #16074

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Document and rename overload-overlap error code #16074

merged 3 commits into from
Sep 10, 2023

Commits on Sep 9, 2023

  1. Document and rename overlap-overload error code 

    A new error code was introduced in
python#16061

As per python#16068, we didn't previously
run doc builds on changes to errorcodes.py, causing tests to fail on
master when this was merged.

Renaming the code as per:
python#16061 (comment)
All type ignores should be unsafe, so we should save the unsafe
adjective for things that are really unsafe. As it stands, there are
many cases where overloads overlap somewhat benignly.
    @hauntsaninja
    hauntsaninja committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    68c6e30 View commit details
    Browse the repository at this point in the history

  2. more detail

    @hauntsaninja
    hauntsaninja committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    aac97d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Alex Waygood <[email protected]>
    @hauntsaninja @AlexWaygood
    hauntsaninja and AlexWaygood authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0709305 View commit details
    Browse the repository at this point in the history