Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub Actions specs #15965

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Improve GitHub Actions specs #15965

merged 1 commit into from
Aug 29, 2023

Conversation

sobolevn
Copy link
Member

Two main changes:

  1. Always use secure permissions, when some workflow does not do anything, it has to be contents: read only
  2. Be more consistent with canceling workflows

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sobolevn sobolevn merged commit 6c16143 into master Aug 29, 2023
17 checks passed
@sobolevn sobolevn deleted the imporove-github-actions branch August 29, 2023 20:12
@sobolevn
Copy link
Member Author

@AlexWaygood
Copy link
Member

Looks like I broke something: https://github.com/python/mypy/actions/runs/6017051995/job/16322380076

Nah, something was already broken — take a look at the CI on #15986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants