Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates error when staticmethod and classmethod decorators are both used #15118

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Generates error when staticmethod and classmethod decorators are both used #15118

merged 6 commits into from
Apr 24, 2023

Conversation

jkchandalia
Copy link
Contributor

Fixes #14506

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JukkaL
JukkaL approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good.

@JukkaL JukkaL merged commit fe8873f into python:master Apr 24, 2023
@jkchandalia jkchandalia deleted the either_static_or_class branch April 24, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no error when marking a method as both staticmethod and classmethod
2 participants
@jkchandalia @JukkaL