-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow iterable class objects to be unpacked #14803
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Mar 1, 2023
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Mar 2, 2023
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
I found a much better solution, which also fixes the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mypy issues a false positive on this code, where
Foo
is iterable by virtue of havingMeta
as its metaclass:This PR fixes that false positive.
I started working on this PR hoping to address #14782, but wasn't able to -- this PR improves the situation somewhat, but doesn't close the issue. Prior to this PR, mypy had this behaviour:
With this PR, mypy has this behaviour instead:
This is because there's a
TypeVar
being used in typeshed's stub forEnumMeta.__iter__
: I wasn't able to figure out how to get mypy to solve the type variable in this context.