-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signature for attr.evolve #14526
Merged
Merged
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cd832cc
wip
ikonst 64a9e58
more resilient
ikonst c145514
hmpf
ikonst 3477d2d
wip
ikonst 056ac66
rely on ExpressionChecker.accept :|
ikonst 8b7f3ca
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst d976202
handle Any, more tests
ikonst 1bdd315
make type-checker happy
ikonst 4c8138d
nits
ikonst 46026fe
teach fixtures about dict for kwargs
ikonst 2316b06
fix random test failures
ikonst 5148e5f
style
ikonst cf756d1
improve tests
ikonst 34c8c94
another test
ikonst 87a4c0b
clarify evolve of _what_
ikonst 0976f86
CallableType.copy_modified: arg_name is sequence
ikonst babf91f
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst 5443d51
break up evolve tests
ikonst 5271233
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst bfcb366
clarify signature
ikonst 0b79cc1
Merge branch 'master' into 2023-01-25-attrs-evolve
ikonst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s also
attrs.evolve()
- maybe that’s just an alias and will work, but it should be tested. Perhaps these should be moved to a constant with the others at the start of the attrs plug-in module also?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, yep. All still WIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready now!