Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary files to stubgen blacklisted path #14447

Closed
wants to merge 1 commit into from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jan 14, 2023

Add binary files to stubgen blacklisted path. .so for Linux and macOS. .dll for Windows.
Fixes #14028

References: https://github.com/python/typeshed/tree/main/stubs/pywin32 and https://github.com/python/typeshed/tree/main/stubs/tree-sitter-languages/%40tests

@Avasam
Copy link
Contributor Author

Avasam commented Jan 14, 2023

I'm not convinced whether this is the right approach. And as can be seen in the tree-sitter-languages stub, it might be good if stubtest also didn't try to parse .so files (?)

@hauntsaninja
Copy link
Collaborator

I'm not sure this is the right approach. I opened an alternative here: #14503
I don't have access to a Windows system, mind confirming whether that fixes?

@hauntsaninja
Copy link
Collaborator

Closing, since Jukka merged the other one. But please let me know if it doesn't work for you!

@Avasam Avasam deleted the Fix-#14028 branch January 23, 2023 01:33
@Avasam
Copy link
Contributor Author

Avasam commented Jan 23, 2023

Just tried latest master and it works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stubgen crash when a referenced module is a DLL
3 participants