Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conf] Allow trailing commas in ini configuration of multiline values #14240

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 3, 2022

Now these two samples are identical:

[mypy]
enable_error_code =
  truthy-bool,
  redundant-expr,
  unused-awaitable,
  ignore-without-code

and

[mypy]
enable_error_code =
  truthy-bool,
  redundant-expr,
  unused-awaitable,
  ignore-without-code,

I've covered some of the changed values, but not all (they are identical - no need to create so many slow tests).

I've also checked pyproject.toml. It does not have this problem: it uses [] to create arrays, so no trailing commas are used there.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@hauntsaninja hauntsaninja merged commit d2ab2e7 into python:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants