Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More helpful type guards #14238

Merged
merged 9 commits into from
Jan 31, 2023
Merged

More helpful type guards #14238

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a29a6ec
The specification requires positional arguments
A5rocks Dec 3, 2022
3dda329
Start allowing keyword arguments to type guards
A5rocks Dec 3, 2022
10c7e3f
Special case staticmethod
A5rocks Dec 3, 2022
3ea4baf
PR review
A5rocks Dec 5, 2022
9c9a791
Fix tests
A5rocks Dec 8, 2022
43adc46
Small test fixes
A5rocks Dec 10, 2022
58af039
Merge branch 'master' into typeguard-ocd
A5rocks Dec 10, 2022
c6f55d1
Move Python 3.8 tests to check-python38
A5rocks Dec 11, 2022
e7265c4
Merge branch 'master' into typeguard-ocd
hauntsaninja Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test-data/unit/check-typeguard.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ if typeguard(n):
reveal_type(n)
[builtins fixtures/tuple.pyi]
[out]
main:4: error: invalid syntax
main:4: error: invalid syntax; you likely need to run mypy using Python 3.8 or newer
A5rocks marked this conversation as resolved.
Show resolved Hide resolved
[out version>=3.8]
main:9: note: Revealed type is "builtins.int"

Expand All @@ -655,7 +655,7 @@ if typeguard(x=(n := cast(object, "hi"))):
reveal_type(n)
[builtins fixtures/tuple.pyi]
[out]
main:8: error: invalid syntax
main:8: error: invalid syntax; you likely need to run mypy using Python 3.8 or newer
[out version>=3.8]
main:9: note: Revealed type is "builtins.int"

Expand Down