[use before def] handle class and function definitions #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilinum
changed the title
ilinum
force-pushed
the
partial/classdefs
branch
from
3c5d21e
to
82c8c9b
Compare
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Nov 27, 2022
| @@ -435,6 +439,10 @@ def visit_with_stmt(self, o: WithStmt) -> None: | |||
| self.process_lvalue(idx) | |||
| o.body.accept(self) | |||
|
|
|||
| def visit_class_def(self, o: ClassDef) -> None: | |||
| self.process_definition(o.name) | |||
There was a problem hiding this comment.
Why do we have enter_scope() for functions but not for classes? A variable defined in a class body will not be visible outside (as a variable, will still be available as an attribute of course)
There was a problem hiding this comment.
Yep, good point. Added enter and exit scope calls (with tests that were failing before)
| [case testUseBeforeDefFunc] | ||
| # flags: --enable-error-code partially-defined --enable-error-code use-before-def | ||
| foo() # E: Name "foo" is used before definition | ||
| def foo(): pass |
There was a problem hiding this comment.
Just in case, could you please add test for classes within functions and vice versa? Also maybe add a test where a variable is defined in a class and then is being red outside of class.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would ignore any class definitions and would fail to detect undefined classes and functions. This updates the logic to handle them.
Closes #686