Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless parameter script_path of main() #13399

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Remove useless parameter script_path of main() #13399

merged 2 commits into from
Aug 14, 2022

Conversation

97littleleaf11
Copy link
Collaborator

script_path was entirely useless since bin_dir had been dropped long time ago by #5690

hauntsaninja
hauntsaninja reviewed Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch to using keyword-only args? There are people who use mypy.main directly and this will ensure they break in obvious ways.

@97littleleaf11
Copy link
Collaborator Author

Can we switch to using keyword-only args? There are people who use mypy.main directly and this will ensure they break in obvious ways.

Make sense!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@97littleleaf11 97littleleaf11 merged commit 599af7f into python:master Aug 14, 2022
@97littleleaf11 97littleleaf11 deleted the fix-main branch August 14, 2022 18:40
@matthewhughes934 matthewhughes934 mentioned this pull request Aug 23, 2022
Merged
rpmcginty added a commit to rpmcginty/dataclasses-json that referenced this pull request Sep 27, 2022
@rpmcginty
Update usage of mypy.main in test following updates to mypy package
6a5a501 
Last month, a mypy change was released that made all arguments
for the mypy.main method keyword only.

python/mypy#13399

The alternative to this change is to freeze your version of mypy
@rpmcginty rpmcginty mentioned this pull request Sep 27, 2022
Merged
This was referenced Dec 12, 2022
Closed
Closed
lidatong pushed a commit to lidatong/dataclasses-json that referenced this pull request Mar 18, 2023
@rpmcginty
Update usage of mypy.main in test following updates to mypy package (#…
b76744b 
…374)

Last month, a mypy change was released that made all arguments
for the mypy.main method keyword only.

python/mypy#13399

The alternative to this change is to freeze your version of mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@97littleleaf11 @hauntsaninja