Fix join of Any against a union type #12068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the join of a union type and Any commutative. Previously the result dependend on the order of the operands, which was clearly incorrect. Fix #12051, but other use cases are affected as well.
sobolevn
reviewed
Jan 25, 2022
| @@ -1881,4 +1881,8 @@ class C(IntEnum): | |||
| def f1(c: C) -> None: | |||
| x = {'x': c.value} | |||
| reveal_type(x) # N: Revealed type is "builtins.dict[builtins.str*, builtins.int]" | |||
|
|
|||
| def f2(c: C, a: Any) -> None: | |||
| x = {'x': c.value, 'y': a} | |||
There was a problem hiding this comment.
Will y = {'y': a, 'x': c.value} be helpful here as well?
There was a problem hiding this comment.
That's a good idea, I'll add it here.
|
I'm going to merge this without waiting for code review, since the changes was approved in #12054. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the join of a union type and Any commutative.
Previously the result dependend on the order of the operands,
which was clearly incorrect.
Fix #12051, but other use cases are affected as well.
This change was split off from #12054.