Fixes how ** affects inference in {} expressions, refs #11691
#11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Dec 9, 2021
| @@ -3334,13 +3334,14 @@ def check_lst_expr(self, items: List[Expression], fullname: str, | |||
| self.chk.named_generic_type(fullname, [tv]), | |||
| self.named_type('builtins.function'), | |||
| name=tag, | |||
| variables=[tv]) | |||
| out = self.check_call(constructor, | |||
There was a problem hiding this comment.
This is a readability change only. Before and after:
This comment has been minimized.
This comment has been minimized.
sobolevn
commented
Dec 9, 2021
mypy/join.py
Outdated
| key, value = extract_key_value_types(item, mapping_type) | ||
| keys.append(key) | ||
| values.append(value) | ||
| return join_type_list(keys), join_type_list(values) |
There was a problem hiding this comment.
I think that we also need to handle: NoReturn and TypedDict types here. Any others?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A5rocks
reviewed
Dec 10, 2021
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: graphql-core (https://github.com/graphql-python/graphql-core)
+ src/graphql/utilities/extend_schema.py:200: error: Unused "type: ignore" comment
+ src/graphql/utilities/extend_schema.py:245: error: Unused "type: ignore" comment
+ src/graphql/utilities/extend_schema.py:353: error: Unused "type: ignore" comment
+ src/graphql/utilities/extend_schema.py:362: error: Unused "type: ignore" comment
pandera (https://github.com/pandera-dev/pandera)
+ pandera/schemas.py:324: error: Incompatible return value type (got "Dict[Any, object]", expected "Dict[str, str]") [return-value]
rclip (https://github.com/yurijmikhalevich/rclip)
- rclip/db.py:70: error: Argument 1 to "update" of "dict" has incompatible type "NewImage"; expected "Mapping[Any, None]"
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/base/sql/registry/main.py:361: error: Argument 1 to "update" of "dict" has incompatible type "Dict[AnnotableMeta, Any]"; expected "Mapping[Type[Node], Any]"
- ibis/backends/impala/compiler.py:25: error: Argument 1 to "update" of "dict" has incompatible type "Dict[AnnotableMeta, Any]"; expected "Mapping[Type[Node], Any]"
+ ibis/backends/clickhouse/compiler.py:69: error: Incompatible types in assignment (expression has type "Dict[Type[Node], Any]", base class "ExprTranslator" defined the type as "Dict[AnnotableMeta, Any]")
black (https://github.com/psf/black)
+ src/blib2to3/pgen2/tokenize.py:581:31: error: Incompatible types in assignment (expression has type "Optional[Pattern[str]]", variable has type "Pattern[str]")
+ src/blib2to3/pgen2/tokenize.py:603:29: error: Incompatible types in assignment (expression has type "Optional[Pattern[str]]", variable has type "Pattern[str]")
core (https://github.com/home-assistant/core)
+ homeassistant/components/sentry/__init__.py:207: error: Unused "type: ignore" comment
|
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quite common problem, I've seen multiple issue reports about this.
So, the problem is: when a person uses
{**kwargs}, it uses the same logic we have for.update()call. But, this is not right..update()indeed needs matching types.But, unpacking into a new dict should be allowed with any values.
To achive that I've decided to use
joinfor key and value types. This is how it works:You may ask: why not
Union?dict[Union[type, float], str]looks strange to me. Also, some other similar places usejoin. But, I am open to discuss this.I will add extra tests a bit later, I am currently too tired 😞
Closes #11691
Refs #11151