Optimize CallableType.formal_arguments #11543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use a generator, since they tend to be slow when compiled.
|
Related to #11547. |
MarkCBell
added a commit
to MarkCBell/mypy
that referenced
this pull request
Dec 29, 2021
PR python#11543 changed the `formal_arguments` method to return a list of formal arguments instead of yielding them. However the docstring was not updated at the time to reflect this.
JelleZijlstra
pushed a commit
that referenced
this pull request
Jan 9, 2022
PR #11543 changed the `formal_arguments` method to return a list of formal arguments instead of yielding them. However the docstring was not updated at the time to reflect this.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Don't use a generator, since they tend to be slow when compiled. This method came up as a hot spot when profiling compiled mypy.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
PR python#11543 changed the `formal_arguments` method to return a list of formal arguments instead of yielding them. However the docstring was not updated at the time to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use a generator, since they tend to be slow when compiled.
This method came up as a hot spot when profiling compiled mypy.