Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now all .clean_copy() calls do not use .disable_count = 0 #11459

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Now all .clean_copy() calls do not use .disable_count = 0 #11459

merged 3 commits into from
Nov 5, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 4, 2021

Since .clean_copy() already ensures that .disable_count is 0, there's no need to set it once again.

Follow up to #11451

right_variants = [(item, TempNode(item, context=context))
for item in flatten_nested_unions(right_type.relevant_items(),
handle_type_alias_type=True)]
right_variants = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is unrelated, but it was completely unreadable:
Снимок экрана 2021-11-04 в 19 22 36

After:
Снимок экрана 2021-11-04 в 19 25 41

@github-actions

This comment has been minimized.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@JukkaL JukkaL merged commit 06cd503 into python:master Nov 5, 2021
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants