Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes how errors are disabled in visit_comparison_expr #11451

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Changes how errors are disabled in visit_comparison_expr #11451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23795c5
Changes how errors are disabled in `visit_comparison_expr`
sobolevn Nov 3, 2021
9b9524c
Change `copy()` -> `clean_copy()`
sobolevn Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,10 +2230,15 @@ def visit_comparison_expr(self, e: ComparisonExpr) -> Type:

# Keep track of whether we get type check errors (these won't be reported, they
# are just to verify whether something is valid typing wise).
local_errors = self.msg.copy()
local_errors.disable_count = 0
local_errors = self.msg.clean_copy()
_, method_type = self.check_method_call_by_name(
'__contains__', right_type, [left], [ARG_POS], e, local_errors)
method='__contains__',
base_type=right_type,
args=[left],
arg_kinds=[ARG_POS],
context=e,
local_errors=local_errors,
)
sub_result = self.bool_type()
# Container item type for strict type overlap checks. Note: we need to only
# check for nominal type, because a usual "Unsupported operands for in"
Expand Down