Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct example annotation self #11133

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Correct example annotation self #11133

merged 1 commit into from
Sep 19, 2021

Conversation

ryan-gunderson
Copy link
Contributor

Add needed covariant=True for example to pass type checking at page.first_chunk() as intended.

@ryan-gunderson
Correct example annotation self
04a44af 
Add needed `covariant=True` for example to pass type checking at `page.first_chunk()` as intended.
hauntsaninja
hauntsaninja approved these changes Sep 19, 2021
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@hauntsaninja hauntsaninja merged commit b165e42 into python:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-gunderson @hauntsaninja