Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue an error when overriding typeguard with non-typeguard in subclass #10300

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Issue an error when overriding typeguard with non-typeguard in subclass #10300

merged 2 commits into from
Apr 12, 2021

Conversation

kamilturek
Copy link
Contributor

Description

Closes #9928.

Issue an error about incompatible signature when trying to override typeguard method with non-typeguard one.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@JukkaL JukkaL merged commit 49cd412 into python:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP 647: Error if overriding typeguard with non-typeguard in subclass
2 participants