Skip to content

Commit

Permalink
[stubtest] Verify __all__ exists in stub (#18005)
Browse files Browse the repository at this point in the history
Previously it wasn't an error if runtime included an
`__all__` declaration, but the stubs did not. This PR
changes this to reflect the consensus that it would
be a good idea to ensure consistency in this case.

Fixes #13300
  • Loading branch information
srittau authored Oct 23, 2024
1 parent 9e68959 commit eb0575e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions mypy/stubtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ def verify_mypyfile(
# Only verify the contents of the stub's __all__
# if the stub actually defines __all__
yield from _verify_exported_names(object_path, stub, runtime_all_as_set)
else:
yield Error(object_path + ["__all__"], "is not present in stub", MISSING, runtime)
else:
runtime_all_as_set = None

Expand Down
4 changes: 2 additions & 2 deletions mypy/test/teststubtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ def test_all_at_runtime_not_stub(self) -> Iterator[Case]:
runtime="""
__all__ = []
Z = 5""",
error=None,
error="__all__",
)

@collect_cases
Expand Down Expand Up @@ -1443,7 +1443,7 @@ def h(x: str): ...
runtime="",
error="h",
)
yield Case(stub="", runtime="__all__ = []", error=None) # dummy case
yield Case(stub="", runtime="__all__ = []", error="__all__") # dummy case
yield Case(stub="", runtime="__all__ += ['y']\ny = 5", error="y")
yield Case(stub="", runtime="__all__ += ['g']\ndef g(): pass", error="g")
# Here we should only check that runtime has B, since the stub explicitly re-exports it
Expand Down

0 comments on commit eb0575e

Please sign in to comment.