Skip to content

Commit

Permalink
Remove TODO / comment around suppress_unreachable_warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ikonst committed Jul 23, 2023
1 parent 2a95a6d commit a090d56
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions mypy/binder.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ def __init__(self, id: int, conditional_frame: bool = False) -> None:
self.types: dict[Key, Type] = {}
self.unreachable = False
self.conditional_frame = conditional_frame

# Should be set only if we're entering a frame where it's not
# possible to accurately determine whether or not contained
# statements will be unreachable or not.
#
# Long-term, we should improve mypy to the point where we no longer
# need this field.
self.suppress_unreachable_warnings = False

def __repr__(self) -> str:
Expand Down Expand Up @@ -174,7 +167,6 @@ def is_unreachable(self) -> bool:
return any(f.unreachable for f in self.frames)

def is_unreachable_warning_suppressed(self) -> bool:
# TODO: See todo in 'is_unreachable'
return any(f.suppress_unreachable_warnings for f in self.frames)

def cleanse(self, expr: Expression) -> None:
Expand Down

0 comments on commit a090d56

Please sign in to comment.