Skip to content

Commit

Permalink
Make PEP561 tests opt-in (fix #12879) (#12883)
Browse files Browse the repository at this point in the history
  • Loading branch information
erikkemperman authored May 29, 2022
1 parent 568b98a commit 2051024
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions runtests.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,14 @@
]


# This must be enabled by explicitly including 'pytest-extra' on the command line
PYTEST_OPT_IN = [PEP561]


# These must be enabled by explicitly including 'mypyc-extra' on the command line.
MYPYC_OPT_IN = [MYPYC_RUN, MYPYC_RUN_MULTI]


# We split the pytest run into three parts to improve test
# parallelization. Each run should have tests that each take a roughly similar
# time to run.
Expand All @@ -64,14 +69,14 @@
ERROR_STREAM])],

# Test cases that might take minutes to run
'pytest-slower': ['pytest', '-q', '-k', ' or '.join(
[PEP561])],
'pytest-extra': ['pytest', '-q', '-k', ' or '.join(PYTEST_OPT_IN)],

# Test cases to run in typeshed CI
'typeshed-ci': ['pytest', '-q', '-k', ' or '.join([CMDLINE,
EVALUATION,
SAMPLES,
TYPESHED])],

# Mypyc tests that aren't run by default, since they are slow and rarely
# fail for commits that don't touch mypyc
'mypyc-extra': ['pytest', '-q', '-k', ' or '.join(MYPYC_OPT_IN)],
Expand All @@ -80,7 +85,8 @@
# Stop run immediately if these commands fail
FAST_FAIL = ['self', 'lint']

DEFAULT_COMMANDS = [cmd for cmd in cmds if cmd not in ('mypyc-extra', 'typeshed-ci')]
EXTRA_COMMANDS = ('pytest-extra', 'mypyc-extra', 'typeshed-ci')
DEFAULT_COMMANDS = [cmd for cmd in cmds if cmd not in EXTRA_COMMANDS]

assert all(cmd in cmds for cmd in FAST_FAIL)

Expand Down Expand Up @@ -124,7 +130,8 @@ def main() -> None:
if not set(args).issubset(cmds):
print("usage:", prog, " ".join('[%s]' % k for k in cmds))
print()
print('Run the given tests. If given no arguments, run everything except mypyc-extra.')
print('Run the given tests. If given no arguments, run everything except'
+ ' pytest-extra and mypyc-extra.')
exit(1)

if not args:
Expand Down

0 comments on commit 2051024

Please sign in to comment.