Apache license incorrectly applied #387
Comments
|
This project is based on jaraco/skeleton. For more information on my opinion on license files, see jaraco/skeleton#1. I really don't want to spend a lot of time fussing about the license. This project (and importlib_resources) use the Apache 2.0 license based on the preference of warsaw. My preference would be to simply license it under MIT. At first, I thought you were mistaken, that the Apache 2.0 guidance indicated to put the small boilerplate in the LICENSE file, but now that I read it again, I think you may be right, that the full text of the license should be included in the file. I'm not interested in littering the rest of the repo or files with licensing details, especially since the source files are synced with CPython and relicensed under the PSF license. Moreover, external sources seem to agree that the license as supplied is adequate enough to recognize the correct license:
I'm on the fence as to whether or not to replace the content of the license file with the full license text. I guess it's more proper to have the full text (and more correct not to mention "this file"). So I'll proceed to make that change. |
|
Hi Jason, thanks for putting the full license file in there. I agree that this legal stuff is a pain in the ass. I'd rather be coding.
As I understand it this is not required as the same license applies to the whole bundle. Greetings, Torsten |
…11.4 to version 4.12.0
Anderson Bravalheri (1):
Update Github actions to v3 (#62)
Hugo van Kemenade (1):
Update base URL for PEPs (#61)
Jason R. Coombs (14):
Fix bug in changelog
Fix reference in docs build.
Add Python 3.11 into the matrix using workaround from actions/setup-python#213. Drop 3.9 from matrix for efficiency.
Prefer spaces for rst. Fixes jaraco/skeleton#64.
Update license. Fixes python/importlib_metadata#387.
Honor PEP 518 with pytest-enabler.
Exclude pip-run from coverage. It's just noise.
Add xfail test capturing new expectation.
Add comment about the compatibility factor.
In Distribution.from_name, require a non-empty string. Fixes python/cpython#93259.
Refactor Distribution.from_name to avoid return in loop and unnecessary None sentinel.
In Distribution.from_name, re-use discover.
Update changelog
Fix reference in docs build.
Sviatoslav Sydorenko (1):
Inject check job into CI workflow as ultimate flag (#55)
wim glenn (1):
exclude build env from cov reporting (#60)
….8.0 to version 5.9.0
Jason R. Coombs (30):
Add Tidelift template
Rely on alabaster theme to support sidebar rendering.
Use nicer, simpler phrasing
Add support for automatic publishing of release notes
Use technique for environment passing matching that found in jaraco/skeleton
Move Tidelift token into Travis configuration
Update badge URL
Add funding reference to project
List sidebars to avoid errors looking for template 't'
Rebrand to 'For Enterprise'
Add a 'For Enterprise' section to the README
Include token passthrough for azure pipelines publish stage.
Move Tidelift release note publishing to Github Actions.
Tidelift no longer requires or expects publishing release notes.
Remove Tidelift from main.yml, no longer needed
Implement tidelift banner using a Sphinx directive implemented by jaraco.tidelift.
Use mod. Fixes doc build failures.
Update license. Fixes python/importlib_metadata#387.
Honor PEP 518 with pytest-enabler.
Add test capturing expectation revealed by #253.
Suppress all TraversalErrors in MultiplexedPath. Fixes #253.
Update changelog. Ref #253.
Add _common._as_tree to demonstrate a directory of resources.
Remove type hints as they're causing trouble.
Allow as_file to return a context manager for a directory or a file as needed.
Rewrite _temp_dir so that it produces a directory of the same name as the input path.
Add test capturing new expectation that subdirectories are supported.
Update changelog.
Ran pre-commit autoupdate
Extract function for _is_present_dir.
chanicpanic (1):
Docs: Change isdir() to is_dir()
Hi all,
during a license review I came across
importlib_metadatawhich appears to be required by one of our third-party packages (actually it gets pulled by setuptools).Looking at the file LICENSE I found this:
Which would make much more sense if applied to individual source files 😉
In fact, https://www.apache.org/licenses/LICENSE-2.0.html#apply states:
IMO this means that the file
LICENSEshould be a verbatim copy of https://www.apache.org/licenses/LICENSE-2.0.txtThe file
NOTICEshould mention the copyright owner and the individual source files would carry the boiler plate currently included asLICENSEfile. This is how apache httpd does it:If you like, I'll be glad to open a pull request.
Greetings, Torsten
The text was updated successfully, but these errors were encountered: