Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on Python 3.8 #100

Closed
jaraco opened this issue Oct 22, 2020 · 12 comments
Closed

Tests failing on Python 3.8 #100

jaraco opened this issue Oct 22, 2020 · 12 comments

Comments

@jaraco
Copy link
Member

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 02:16

Since the release of Python 3.8, the tests have started failing, even though they were passing on early releases of Python 3.8.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 02:18

Re-running the pipelines against master, which passed tests when 0.24 was released, there are now two tests failing that passed before. This issue is to address the emergent failure on Python 3.8.

py38 run-test: commands[0] | python -m unittest discover
132 ..........................F....................
133 ======================================================================
134 FAIL: test_package_discovery (importlib_metadata.tests.test_main.DiscoveryTests)
135 ----------------------------------------------------------------------
136 Traceback (most recent call last):
137   File "/builds/python-devs/importlib_metadata/importlib_metadata/tests/test_main.py", line 160, in test_package_discovery
138     assert all(
139 AssertionError
140 ----------------------------------------------------------------------
141 Ran 47 tests in 0.286s
142 FAILED (failures=1)
143 ERROR: InvocationError for command /builds/python-devs/importlib_metadata/.tox/py38/bin/python -m unittest discover (exited with code 1)

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 02:35

The failed assertion is probably another manifestation of #91 - because Distribution is defined in two places.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 02:47

mentioned in commit 255b695e062e369a6af16bf76243e476afc36a1b

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 09:32

changed title from {-test_discovery-} failing on Python 3.8 to {+Tests+} failing on Python 3.8

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 09:32

changed the description

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 09:33

changed the description

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 09:33

It's worse than I'd imagined. The coverage tests are also failing, due to the stdlib functionality taking precedence. I think a solution that also addresses #91 may be necessary to address this issue.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 09:50

mentioned in commit 73427ca

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 10:10

mentioned in merge request !98

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 19:29

closed via merge request !98

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 19:29

mentioned in commit c854e9a

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 30, 2019, 19:29

closed via commit 73427ca

@jaraco jaraco closed this as completed Oct 22, 2020
jaraco added a commit that referenced this issue Dec 21, 2023
jaraco added a commit that referenced this issue Dec 21, 2023
Remove __version__

Closes #100

See merge request python-devs/importlib_resources!105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant