Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include languages' translated names in the switcher #245

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jan 24, 2025

An alternative to #244 (closes #244, #238 if merged).

I think it is cleaner to use a new attribute for the local/translated/native name for each language, rather than overloading the name field. I agree with @encukou that the English name should come first, and that we should not de-emphasise the other name by using brackets for it.

cc @StanFromIreland @rffontenelle @m-aciek as I can't request you as reviewers.

A

config.toml Outdated Show resolved Hide resolved
@StanFromIreland
Copy link
Contributor

@JulienPalard @oonid @alessandrocucci @cocoatomo @flowdas @zhsj @mattwang44 @egeakman @raulcd

I cannot request reviews. Pining coordianators to settle capitalization.

@StanFromIreland
Copy link
Contributor

Is it overloading the name field? In my opinion this is a little over complicated for static text that can be pre-stored as a string. It has no effect on the end user and is easier for us as the logic is simpler while still being well below 80 chars.

@AA-Turner
Copy link
Member Author

settle capitalization

I'm unsure what you mean here? Language names are proper nouns so must be capitalised. Did you ping people just to check spelling? Just for the future, it may be better to check these questions before pinging lots of people.

A

@encukou
Copy link
Member

encukou commented Jan 24, 2025 via email

@StanFromIreland
Copy link
Contributor

@AA-Turner Apologies, I assumed you had read the long exchange in my PR where this question had been asked. Petr has linked it.

Co-authored-by: Ezio Melotti <[email protected]>
config.toml Outdated Show resolved Hide resolved
Co-authored-by: Rafael Fontenelle <[email protected]>
@AA-Turner
Copy link
Member Author

Thanks for linking to the thread!

This table from Wikipedia suggests the following translations for languages.

Name Translated name
German Deutsch
Spanish español
French français
Indonesian bahasa Indonesia
Italian italiano; lingua italiana
Polish Język polski
Turkish Türkçe
Ukrainian Українська мова; Українська

Other sources:

  • Spanish (no capitalisation): [ref]
  • French (no capitalisation): [ref]
  • Indonesian (capitalisation): [ref] (unclear if we should use "Indonesia" or "bahasa Indonesia", though -- the latter seems to refer specifically to standard Indonesian.
  • Italian (no capitalisation): [ref]
  • Polish (no capitalisation per @m-aciek): unclear whether to use the "Język" prefix.
  • Turkish (capitalisation): [ref]
  • Ukrainian (no capitalisation): [ref] (this disagrees with the Wikipedia list)

A

Copy link

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the common translations of Chinese in other language switches.

config.toml Outdated Show resolved Hide resolved
config.toml Outdated Show resolved Hide resolved
Copy link

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Spanish translation point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants