Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label names in the triaging section #821

Closed
Tracked by #13
ezio-melotti opened this issue Mar 25, 2022 · 9 comments · Fixed by #930
Closed
Tracked by #13

Update label names in the triaging section #821

ezio-melotti opened this issue Mar 25, 2022 · 9 comments · Fixed by #930

Comments

@ezio-melotti
Copy link
Member

The labels used in the python/cpython repo have been updated In python/core-workflow#432 and python/bedevere#419.

https://devguide.python.org/triaging/ should be updated accordingly.

https://discuss.python.org/t/github-issues-migration-label-mapping/14212 has more information about the labels.

@pgadige
Copy link

pgadige commented Mar 28, 2022

@Mariatta I'm working on this one. May I share a draft PR?

@JelleZijlstra
Copy link
Member

Feel free to open a PR, thanks for your work! (Not Mariatta but pretty sure she'd agree.)

@Mariatta
Copy link
Member

Sure @pgadige go for it.

@ezio-melotti
Copy link
Member Author

@pgadige, are you still working on this?

@pgadige
Copy link

pgadige commented Apr 18, 2022

@ezio-melotti Yes, I'm working on it. I was MIA for a few days due to a personal urgency.

@ezio-melotti
Copy link
Member Author

ezio-melotti commented Apr 18, 2022

Now that the migration is done, labels are documented in three places:

We are also still updating labels and their names as we adapt to the new workflow, which means that whenever we add/remove/update a label, we also have to update the devguide.

It might be easier to just link to the labels page on python/cpython, however not all labels there have descriptions. This is intentional since some of them are self-explanatory and adding descriptions clutters the "labels" dropdown.

Maybe the best approach would be to document groups of labels1 and labels that trigger bots or have special meanings and then link to https://github.com/python/cpython/labels for the full list.

Footnotes

  1. see https://github.com/python/core-workflow/issues/450

za added a commit to za/devguide that referenced this issue Jun 4, 2022
WIP: still need to add the description.

Refer to this merged PR:
https://github.com/python/bedevere/pull/419/files

GH issue:
python#821
@za
Copy link
Contributor

za commented Jun 4, 2022

Hi @pgadige allow me to initiate the PR. @ezio-melotti I've drafted a PR. Am I in the right direction? I haven't filled the description though.

@za
Copy link
Contributor

za commented Jun 6, 2022

I've added the description.

za added a commit to za/devguide that referenced this issue Jun 7, 2022
@AA-Turner
Copy link
Member

Labels are now consolidated into one place in the devguide (https://devguide.python.org/triage/labels/), but I just cut-and-pasted, so there is rampant duplication and likely a lot of the content is outdated (but no less outdated than previously).

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
6 participants