Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99016: Make build scripts compatible with Python 3.8 #99017

Merged
merged 1 commit into from
Nov 2, 2022
Merged

gh-99016: Make build scripts compatible with Python 3.8 #99017

merged 1 commit into from
Nov 2, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 2, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 2, 2022
@serhiy-storchaka serhiy-storchaka merged commit f520d72 into python:main Nov 2, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the python-for-regen-3.8 branch November 2, 2022 18:30
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f520d720f667c87f7b70ed86ea58d73892d6b969 3.11

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker f520d720f667c87f7b70ed86ea58d73892d6b969 3.10

@AlexWaygood AlexWaygood mentioned this pull request Nov 2, 2022
Closed
@vstinner
Copy link
Member

vstinner commented Nov 3, 2022

Thank you, this issue started to annoy me: it prevented me to merge unrelated changes ;-)

@serhiy-storchaka
Copy link
Member Author

An unrelated failure in your PR was a cause of creating this PR.

@bedevere-bot
Copy link

GH-99693 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 22, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 22, 2022
@serhiy-storchaka
[3.11] pythongh-99016: Make build scripts compatible with Python 3.8 (p…
581e23a 
…ythonGH-99017).

(cherry picked from commit f520d72)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 22, 2022
@serhiy-storchaka
[3.11] gh-99016: Make build scripts compatible with Python 3.8 (GH-99017
49f2eee 
). (GH-99693)

(cherry picked from commit f520d72)
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 only security fixes label Nov 22, 2022
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 22, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @vstinner @bedevere-bot @JelleZijlstra