Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93357: Port test_pep492 to IsolatedAsyncioTestCase #98877

Closed
wants to merge 2 commits into from
Closed

gh-93357: Port test_pep492 to IsolatedAsyncioTestCase #98877

wants to merge 2 commits into from

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Oct 30, 2022 •
edited by bedevere-bot
Loading

This attempt makes way less changes so it shouldn't fail random tests with races.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 30, 2022
@bedevere-bot bedevere-bot mentioned this pull request Mar 22, 2023
Closed
21 tasks
@arhadthedev
Copy link
Member Author

arhadthedev commented Apr 19, 2023 •
edited
Loading

Closing this PR because:

  1. I have no expertise or experience to determine whether another failure of already flaky test_asyncio is caused by my changes (and thus needs to be urgently investigated)
  2. The volume of changes is way larger than I initially expected;
  3. @kumaraditya303 will port essential tests anyway.

@arhadthedev arhadthedev deleted the utilsTestCase-pep492 branch April 19, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Assignees
No one assigned
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arhadthedev @bedevere-bot