[3.10] gh-97514: Don't use Linux abstract sockets for multiprocessing (GH-98501) #98503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-98501) Linux abstract sockets are insecure as they lack any form of filesystem permissions so their use allows anyone on the system to inject code into the process. This removes the default preference for abstract sockets in multiprocessing introduced in Python 3.9+ via python#18866 while fixing python#84031. Explicit use of an abstract socket by a user now generates a RuntimeWarning. If we choose to keep this warning, it should be backported to the 3.7 and 3.8 branches. (cherry picked from commit 49f6106) Co-authored-by: Gregory P. Smith <[email protected]>
bedevere-bot
added
type-bug
gpshead
approved these changes
Oct 20, 2022
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Jul 11, 2023
looks like we are using a very early release of python 3.10 and we didn't got the revert that was done in python/cpython#98503 rebuilding image with latest release of python 3.10 Fixes: scylladb#6345 Ref: python/cpython#98503
12 tasks
fruch
added a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Jul 11, 2023
looks like we are using a very early release of python 3.10 and we didn't got the revert that was done in python/cpython#98503 rebuilding image with latest release of python 3.10 Fixes: #6345 Ref: python/cpython#98503
fruch
added a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Jul 11, 2023
looks like we are using a very early release of python 3.10 and we didn't got the revert that was done in python/cpython#98503 rebuilding image with latest release of python 3.10 Fixes: #6345 Ref: python/cpython#98503 (cherry picked from commit 61bd889)
soyacz
pushed a commit
to soyacz/scylla-cluster-tests
that referenced
this pull request
May 9, 2024
looks like we are using a very early release of python 3.10 and we didn't got the revert that was done in python/cpython#98503 rebuilding image with latest release of python 3.10 Fixes: scylladb#6345 Ref: python/cpython#98503 (cherry picked from commit 61bd889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux abstract sockets are insecure as they lack any form of filesystem
permissions so their use allows anyone on the system to inject code into
the process.
This removes the default preference for abstract sockets in
multiprocessing introduced in Python 3.9+ via
#18866 while fixing
#84031.
Explicit use of an abstract socket by a user now generates a
RuntimeWarning. If we choose to keep this warning, it should be
backported to the 3.7 and 3.8 branches.
(cherry picked from commit 49f6106)
Co-authored-by: Gregory P. Smith [email protected]
Automerge-Triggered-By: GH:gpshead