Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97681: Remove Tools/demo/ directory #97682

Merged
merged 1 commit into from
Oct 3, 2022
Merged

gh-97681: Remove Tools/demo/ directory #97682

merged 1 commit into from
Oct 3, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Remove the following old demo scripts:

  • beer.py
  • eiffel.py
  • hanoi.py
  • life.py
  • markov.py
  • mcast.py
  • queens.py
  • redemo.py
  • rpython.py
  • rpythond.py
  • sortvisu.py
  • spreadsheet.py
  • vector.py

Changes:

  • Remove a reference to the redemo.py script in the regex howto documentation.
  • Remove a reference to the removed Tools/demo/ directory in the curses documentation.
  • Update PC/layout/ to remove the reference to Tools/demo/ directory.

@vstinner vstinner requested a review from a team as a code owner September 30, 2022 16:36
@vstinner
Copy link
Member Author

Remove a reference to the removed Tools/demo/ directory in the curses documentation.

In fact, only Tools/demo/life.py uses the curses module.

@vstinner
Copy link
Member Author

cc @gvanrossum

gvanrossum
gvanrossum approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I kept a copy of these files in a personal repo: https://github.com/gvanrossum/old-demos

@vstinner
Copy link
Member Author

I kept a copy of these files in a personal repo: https://github.com/gvanrossum/old-demos

Should I add a link to it in the changelog entry ?

@gvanrossum
Copy link
Member

Sure!

@vstinner
gh-97681: Remove the Tools/demo/ directory
b1012ba 
Remove the Tools/demo/ directory which contained old demo scripts. A
copy can be found in the old-demos project:
https://github.com/gvanrossum/old-demos

Remove the following old demo scripts:

* beer.py
* eiffel.py
* hanoi.py
* life.py
* markov.py
* mcast.py
* queens.py
* redemo.py
* rpython.py
* rpythond.py
* sortvisu.py
* spreadsheet.py
* vector.py

Changes:

* Remove a reference to the redemo.py script in the regex howto
  documentation.
* Remove a reference to the removed Tools/demo/ directory in the
  curses documentation.
* Update PC/layout/ to remove the reference to Tools/demo/ directory.
@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2022

I added a link to https://github.com/gvanrossum/old-demos in the change documentation, and I documented the removal of Demos in What's New in Python 3.12.

@vstinner vstinner merged commit 64fe343 into python:main Oct 3, 2022
@vstinner vstinner deleted the remove_demos branch October 3, 2022 15:09
@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2022

Goodbye old demos, enjoy your new home: https://github.com/gvanrossum/old-demos

@gvanrossum
Copy link
Member

Thanks!

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2022

I looked at the first author of each removed demo:

  • Guido van Rossum:

    • mcast (1992)
    • vector (1992)
    • markov (1993)
    • hanoi (1994)
    • rpython (1995)
    • sortvisu (1997)
    • beer (1998)
    • redemo (1998)
    • queens (2000)
    • spreadsheet (2002)

  • Andrew M. Kuchling: life (2000)

  • Jeremy Hylton: eiffel (2002)

Demos were created between 1992 and 2002, and Guido wrote most of them (10 of 12).

carljm added a commit to carljm/cpython that referenced this pull request Oct 3, 2022
@carljm
Merge branch 'main' into dictwatch
e83abac 
* main: (2069 commits)
  pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)
  pythongh-94808: Coverage: Check picklablability of calliter (python#95923)
  pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)
  pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)
  Fix typos in `bltinmodule.c`. (pythonGH-97766)
  pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)
  pythongh-97681: Remove Tools/demo/ directory (python#97682)
  Fix typo in unittest docs (python#97742)
  pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)
  pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)
  pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)
  pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)
  pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)
  pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)
  pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)
  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)
  pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)
  pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)
  pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)
  pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)
  ...
@ezio-melotti ezio-melotti mentioned this pull request Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @gvanrossum @bedevere-bot