Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97669: Remove outdated example scripts #97675

Merged
merged 1 commit into from
Oct 4, 2022
Merged

gh-97669: Remove outdated example scripts #97675

merged 1 commit into from
Oct 4, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Remove outdated example scripts. Copy them from Python 3.11 if you still need them.

Removed scripts:

  • byext.py
  • byteyears.py
  • cleanfuture.py
  • copytime.py
  • crlf.py
  • db2pickle.py
  • dutree.doc
  • dutree.py
  • find-uname.py
  • find_recursionlimit.py
  • finddiv.py
  • findlinksto.py
  • findnocoding.py
  • fixcid.py
  • fixdiv.py
  • fixheader.py
  • fixnotice.py
  • fixps.py
  • get-remote-certificate.py
  • google.py
  • highlight.py
  • ifdef.py
  • import_diagnostics.py
  • lfcr.py
  • linktree.py
  • lll.py
  • mailerdaemon.py
  • make_ctype.py
  • mkreal.py
  • objgraph.py
  • pdeps.py
  • pickle2db.py
  • pindent.py
  • pysource.py
  • reindent-rst.py
  • rgrep.py
  • suff.py
  • texi2html.py
  • which.py

Changes:

  • Remove test_fixcid, test_lll, test_pdeps and test_pindent of test.test_tools.
  • Remove get-remote-certificate.py changelog entry, since the script was removed.
  • FYI there is a copy of crlf.py in Lib/test/test_lib2to3/data/.

@vstinner vstinner mentioned this pull request Sep 30, 2022
Closed
@vstinner
Copy link
Member Author

Here is a first PR to remove scripts which look outdated to me. The remaining ones might be useful or are referenced in other parts of Python, so I prefer to write separated PRs for the other scripts that I plan to remove.

Since my first version, I restored md5sum.py and parse_html5_entities.py removed by mistake. I alsot restored untabify.py since it's used by patchcheck.py.

Note: first I created PR #97674 on the branch name "main" which is not convenient, so I closed it and created this PR instead.

@vstinner vstinner mentioned this pull request Sep 30, 2022
Closed
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 30, 2022 •
edited
Loading

It would be good to preserve at least some of these before this PR (or other PRs) get merged. See my post at https://discuss.python.org/t/remove-outdated-tools-scripts-scripts/19571/22.

I'm okay with simply finding the scripts on the 3.11 branch.

gvanrossum
gvanrossum approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2022

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

Once most scripts will be removed and a copy of these scripts will be created, we can document the removal in What's New In Python 3.12 with a link to this copy.

@warsaw
Copy link
Member

warsaw commented Oct 3, 2022

mailerdaemon.py can probably be replaced (possibly with some wrapper code) with flufl.bounce.

gvanrossum
gvanrossum approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I expect that we may be removing one or two scripts that are still depended on by some platform or workflow, but that's okay -- we'll just restore those when we get complaints.

@gvanrossum
Copy link
Member

And yes, these are now also in my https://github.com/gvanrossum/old-demos repo.

@vstinner
gh-97669: Remove outdated example scripts
483b623 
Remove outdated example scripts of the Tools/scripts/ directory. A
copy can be found in the old-demos project:
https://github.com/gvanrossum/old-demos

Removed scripts (39):

* byext.py
* byteyears.py
* cleanfuture.py
* copytime.py
* crlf.py
* db2pickle.py
* dutree.doc
* dutree.py
* find-uname.py
* find_recursionlimit.py
* finddiv.py
* findlinksto.py
* findnocoding.py
* fixcid.py
* fixdiv.py
* fixheader.py
* fixnotice.py
* fixps.py
* get-remote-certificate.py
* google.py
* highlight.py
* ifdef.py
* import_diagnostics.py
* lfcr.py
* linktree.py
* lll.py
* mailerdaemon.py
* make_ctype.py
* mkreal.py
* objgraph.py
* pdeps.py
* pickle2db.py
* pindent.py
* pysource.py
* reindent-rst.py
* rgrep.py
* suff.py
* texi2html.py
* which.py

Changes:

* Remove test_fixcid, test_lll, test_pdeps and test_pindent
  of test.test_tools.
* Remove get-remote-certificate.py changelog entry, since the script
  was removed.

Note: there is a copy of crlf.py in Lib/test/test_lib2to3/data/.
@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2022

I completed to doc to mention the removal in What's New in Python 3.12 with a link to https://github.com/gvanrossum/old-demos

@vstinner vstinner merged commit 6cbbc26 into python:main Oct 4, 2022
@vstinner vstinner deleted the remove_scripts branch October 4, 2022 08:49
@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2022

Ok, I removed a first batch of outdated scripts.

vstinner added a commit that referenced this pull request Oct 11, 2022
@vstinner
gh-97669: Remove outdated example scripts (#97675) (#98167)
e0ae9dd 
Remove outdated example scripts of the Tools/scripts/ directory:

* gprof2html.py
* md5sum.py
* nm2def.py
* pathfix.py
* win_add2path.py

Remove test_gprof2html, test_md5sum and test_pathfix of test_tools.
@EvanLai88 EvanLai88 mentioned this pull request Jan 15, 2023
Merged
@arhadthedev arhadthedev mentioned this pull request Apr 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@gpshead gpshead gpshead approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vstinner @ericsnowcurrently @warsaw @gvanrossum @gpshead @ezio-melotti @bedevere-bot