Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97545: Make Semaphore run faster. #97549

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

cykerway
Copy link
Contributor

@cykerway cykerway commented Sep 25, 2022

@cykerway cykerway changed the title Make Semaphore run faster. gh-97545: Make Semaphore run faster. Sep 25, 2022
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through this code so many times in my mind, this looks good to me. The silly speed test I wrote to flag this problem runs as fast as it used to. So I'll just merge this and backport to 3.11.

@gvanrossum gvanrossum merged commit 68c46ae into python:main Sep 26, 2022
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @cykerway for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97584 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
@gvanrossum gvanrossum added the needs backport to 3.10 only security fixes label Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @cykerway for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97585 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
miss-islington added a commit that referenced this pull request Sep 26, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
miss-islington added a commit that referenced this pull request Sep 27, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
@@ -0,0 +1 @@
Make Semaphore run faster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very vague and confusing as what Semaphore is made to run faster? threading module or asyncio?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's a good point. It's asyncio.Semaphore. You should be able to create a PR that updates just that particular NEWS file. (And backport it.)

pablogsal pushed a commit that referenced this pull request Oct 24, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
(cherry picked from commit 68c46ae)

Co-authored-by: Cyker Way <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants