[3.10] Override stylesheet fingerprinting for Windows CHM HTML help (gh-91207) #95556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-bot
added
type-bug
CAM-Gerlach
added
docs
|
I guess I'll add a news entry, since this fixes a user-visible bug. |
|
Looks like that did it! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #91207 , this overrides for the
htmlhelpbuilder (legacy Windows CHM files) the stylesheet fingerprinting introduced in python/python-docs-theme#79 to fix the caching issue in python/python-docs-theme#78 , which breaks HTML help rendering.htmlhelpsupport was removed in 3.11, so only targets 3.10.@zooba I tested this locally and it produced the intended result in the
htmlhelpsource files while not affecting other builds, but I cannot be 100% sure it fixes the actual problem without testing it in a real Windows HTML help viewer. Are you or someone else able to do so? Thanks!