gh-84461: Tool/wasm/python.html: Add subresource integrity hashes #93953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subresource integrity hashes are is best practice when using pinned versions of packages, since we don't need to trust the CDN. (I don't mean to imply anything about unpkg in particular; in fact it currently seems quite trustworthy.)
tiran
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
LGTM
I was not aware that modern browsers have this feature. https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 1, 2022
…es (pythonGH-93953) (cherry picked from commit 1df9449) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-94481 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 1, 2022
…-93953) (cherry picked from commit 1df9449) Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subresource integrity hashes are best practice when using pinned versions of packages, since we don't need to trust the CDN.
(I don't mean to imply anything about unpkg in particular; in fact it currently seems quite trustworthy.)