Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-89914: Remove f_globals and f_builtins fields from _PyInterpreterFrame. #92957

Conversation

markshannon
Copy link
Member

This PR removes the f_globals and f_builitns from the _PyInterpreterFrame struct.
It is the first part of faster-cpython/ideas#111 (comment)

It is the simplest part of that idea, and the part that could potentially cause a slowdown, so I though it best to do in its own PR.

Benchmarking shows a 1% slowdown, so it is probably best not to merge this until we can demonstrate a speedup with the rest of faster-cpython/ideas#111 (comment)

@gvanrossum gvanrossum changed the title GH-89914: Remove f_builtins and f_builtins fields from _PyInterpreterFrame. GH-89914: Remove f_globals and f_builtins fields from _PyInterpreterFrame. May 19, 2022
@markshannon
Copy link
Member Author

It looks like faster-cpython/ideas#111 (comment) isn't worth doing, at least not yet.

@markshannon markshannon deleted the remove-globals-builtins-from-frame branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants