gh-61441: XML entity expansion limitation #9265
Draft
+633
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer to see this change made in expat upstream. We should vendor an unmodified version of expat. |
|
That's the plan. |
vstinner
changed the title
tiran
force-pushed
the
bpo17239-expat-limit
branch
from
a172a25 to
053db1d
Compare
|
Since we ship the vendored one as part of the Windows release, I'd be happy to have this merged for 3.7.1 while we wait for the patch to go upstream. This is not our public API, so even if they upstream a different version of it, that won't affect us. |
tiran
force-pushed
the
bpo17239-expat-limit
branch
4 times, most recently
from
6a51752 to
2cffc90
Compare
Modelled after https://github.com/GNOME/libxml2/blob/v2.9.8/parser.c#L99 Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo17239-expat-limit
branch
from
2cffc90 to
504e092
Compare
|
@tiran maybe we could close this issue, +- 1y and I suppose |
|
@tiran Is the PR still relevant? |
| typedef struct { | ||
| ENTITY *first_entity; | ||
| unsigned int entitiesNestingLevel; | ||
| size_t nestedEntitiesExpansionSize; /* in bytes, not XML_Cha) */ |
There was a problem hiding this comment.
Suggested change
| size_t nestedEntitiesExpansionSize; /* in bytes, not XML_Cha) */ | |
| size_t nestedEntitiesExpansionSize; /* in bytes, not XML_Char */ |
erlend-aasland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelled after https://github.com/GNOME/libxml2/blob/v2.9.8/parser.c#L99
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue17239