-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92062: inspect.Parameter
checks whether name
is a keyword
#92065
gh-92062: inspect.Parameter
checks whether name
is a keyword
#92065
Conversation
I just can't understand why |
There is some pre-existing trailing whitespace in the file (around lines 1648 and 1686). |
Jelle pointed out that this might occur in C functions, and so to avoid breaking any existing (if strange) code we'll only check params which can be called with named arguments.
Oh, easy to fix now that I know what's happening! Thanks for the quick response 🤩 (Perhaps the |
This seems like it should be uncontroversial enough (famous last words — I'm sure someone is going to show up complaining that they use invalid signature objects as some load-bearing part of their workflow). |
Fixes #92062.
Automerge-Triggered-By: GH:pganssle