Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-32356: idempotent pause_/resume_reading (GH-4914) #7629

Merged
merged 4 commits into from
Jun 13, 2018
Merged

[3.6] bpo-32356: idempotent pause_/resume_reading (GH-4914) #7629

merged 4 commits into from
Jun 13, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 11, 2018 •
edited by bedevere-bot
Loading

Backport note: don't add new is_reading() method from master to 3.6.

(cherry picked from commit d757aaf)

https://bugs.python.org/issue32356

@1st1 @vstinner
bpo-32356: idempotent pause_/resume_reading (GH-4914)
6b2f524 
Backport note: don't add new is_reading() method from master to 3.6.

(cherry picked from commit d757aaf)
@vstinner vstinner requested a review from 1st1 June 11, 2018 11:54
ned-deily
ned-deily requested changes Jun 11, 2018
View reviewed changes
Doc/library/asyncio-protocol.rst Outdated
@@ -124,11 +124,19 @@ ReadTransport
the protocol's :meth:`data_received` method until :meth:`resume_reading`
is called.

.. versionchanged:: 3.6.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.5 was already released, and you're going to have to hurry to make 3.6.6!

Doc/library/asyncio-protocol.rst Outdated
.. method:: resume_reading()

Resume the receiving end. The protocol's :meth:`data_received` method
will be called once again if some data is available for reading.

.. versionchanged:: 3.6.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.5 -> 3.6.?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Fixed.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily
ned-deily requested changes Jun 13, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be 3.6.7, as it missed the cutoff for 3.6.6,

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member Author

Oh. I missed the notification about 3.6.6 release (cut off). That's fine, it's a minor issue, no need to push it to 3.6.6.

I will merge this PR once 3.6.6 is released.

@vstinner
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@vstinner vstinner merged commit 142e3c0 into python:3.6 Jun 13, 2018
@vstinner vstinner deleted the asyncio_pause branch June 13, 2018 10:05
@vstinner
Copy link
Member Author

I will merge this PR once 3.6.6 is released.

I read again @ned-deily's email: changes merged into 3.6 will be released as 3.6.7. So it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @bedevere-bot @ned-deily @the-knights-who-say-ni @1st1